Change gate for attach mutation #176

15g-lucas · 2025-06-05T18:26:10Z

close #162

I've added the possibility of using the attachModel gate when attaching to the PerformMutate, as indicated in the documentation.

I've left the possibility of using view so as not to create a breaking change.

Summary by CodeRabbit

Bug Fixes
- Improved authorization checks for certain mutation operations, ensuring more specific permissions are verified before falling back to general permissions.
- Updated policy rules to better control access for attaching and detaching various relationship types, enhancing security and permission granularity.
- Adjusted expected view permissions in tests to reflect updated authorization logic, improving accuracy of access control validation.

coderabbitai · 2025-06-05T18:26:16Z

Walkthrough

The authorization logic within the applyMutation method was updated to introduce a conditional check for mutation operations other than 'create' and 'update'. Now, the method first attempts to authorize using a dynamically constructed 'attach' operation before defaulting to the existing 'view' authorization. Additionally, the mutate method's loop was simplified by consolidating the assignment of mutation results.

Changes

File	Change Summary
src/Query/Traits/PerformMutation.php	Simplified array assignment in `mutate`; updated authorization logic in `applyMutation` for non-create/update mutations.
tests/Support/Policies/GreenPolicy.php	Changed `view` method to return `false`; added multiple attach/detach relation authorization methods returning `true`.
tests/Feature/Controllers/AutomaticGatingTest.php	Updated test assertions to expect `authorized_to_view` as `false` instead of `true`.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PerformMutation
    participant Resource

    User->>PerformMutation: applyMutation(mutation, attributes)
    PerformMutation->>Resource: authorizeTo('attach' + model, model)
    alt attach authorization passes
        PerformMutation-->>User: Proceed with mutation
    else attach authorization fails
        PerformMutation->>Resource: authorizeTo('view', model)
        alt view authorization passes
            PerformMutation-->>User: Proceed with mutation
        else view authorization fails
            PerformMutation-->>User: Authorization denied
        end
    end

Assessment against linked issues

Objective	Addressed	Explanation
Ensure that the correct attach policy is called for BelongsTo relationship attachments (#162)	✅	Authorization logic now attempts 'attach' operation before falling back to 'view' operation.

Assessment against linked issues: Out-of-scope changes

Code Change	Explanation
Addition of many attach/detach relation methods in GreenPolicy.php	These methods are broad policy additions not explicitly required by the linked issue #162.
Test assertion updates in AutomaticGatingTest.php	These changes relate to expected authorization flags but are not directly tied to the attach policy issue #162.

Poem

A bunny with code on its mind,
Tweaked permissions, now more refined.
First, try to attach—if that’s not the match,
Then view is the fallback we find.
With hops through the logic, it’s never a chore—
Secure little changes, who could ask for more?
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 49f82ac and 66ff0c6.

📒 Files selected for processing (1)

tests/Feature/Controllers/AutomaticGatingTest.php (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

tests/Feature/Controllers/AutomaticGatingTest.php

⏰ Context from checks skipped due to timeout of 90000ms (18)

GitHub Check: Tests on PHP 8.4 with Laravel ^12.0 and mysql
GitHub Check: Tests on PHP 8.4 with Laravel ^12.0 and pgsql
GitHub Check: Tests on PHP 8.4 with Laravel ^12.0 and sqlite
GitHub Check: Tests on PHP 8.4 with Laravel ^11.0 and sqlite
GitHub Check: Tests on PHP 8.4 with Laravel ^11.0 and mysql
GitHub Check: Tests on PHP 8.4 with Laravel ^11.0 and pgsql
GitHub Check: Tests on PHP 8.3 with Laravel ^12.0 and mysql
GitHub Check: Tests on PHP 8.3 with Laravel ^11.0 and pgsql
GitHub Check: Tests on PHP 8.3 with Laravel ^11.0 and mysql
GitHub Check: Tests on PHP 8.2 with Laravel ^12.0 and pgsql
GitHub Check: Tests on PHP 8.2 with Laravel ^11.0 and sqlite
GitHub Check: Tests on PHP 8.3 with Laravel ^11.0 and sqlite
GitHub Check: Tests on PHP 8.3 with Laravel ^12.0 and pgsql
GitHub Check: Tests on PHP 8.2 with Laravel ^12.0 and sqlite
GitHub Check: Tests on PHP 8.3 with Laravel ^12.0 and sqlite
GitHub Check: Tests on PHP 8.2 with Laravel ^11.0 and pgsql
GitHub Check: Tests on PHP 8.2 with Laravel ^12.0 and mysql
GitHub Check: Tests on PHP 8.2 with Laravel ^11.0 and mysql

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 56fbd7e and 3b5c192.

📒 Files selected for processing (1)

src/Query/Traits/PerformMutation.php (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/Query/Traits/PerformMutation.php (1)

src/Concerns/Authorizable.php (1)

authorizeTo (24-53)

src/Query/Traits/PerformMutation.php

GautierDele · 2025-06-06T19:11:48Z

Oh ! but there are no unit tests on this ? I'll add some with it

GautierDele · 2025-06-10T15:50:02Z

By going further on this issue, there are plenty of tests running for this case, could you provide the specific example giving you the problem ?
If the gate method for attaching is not defined, by default rest api authorizes the attach/detach

Fix gate

3b5c192

coderabbitai bot reviewed Jun 5, 2025

View reviewed changes

src/Query/Traits/PerformMutation.php Outdated Show resolved Hide resolved

15g-lucas added 4 commits June 5, 2025 20:35

Fix styleUi

a9d2dc4

Fix Mutator Authorize fnct

090e201

Fix StyleCI

fae83ff

Fix StyleCI

70f68d5

15g-lucas added 5 commits June 9, 2025 11:05

Add tests and fix PeformMutation

41dda58

Fix tests

49f82ac

Fix styleCI

352bbc0

Fix styleCI

20c7bbe

Fix styleCI

66ff0c6

GautierDele closed this Jun 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Change gate for attach mutation #176

Change gate for attach mutation #176

Uh oh!

15g-lucas commented Jun 5, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 5, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

GautierDele commented Jun 6, 2025 •

edited

Loading

Uh oh!

GautierDele commented Jun 10, 2025

Uh oh!

Uh oh!

Uh oh!

Change gate for attach mutation #176

Change gate for attach mutation #176

Uh oh!

Conversation

15g-lucas commented Jun 5, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

GautierDele commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GautierDele commented Jun 10, 2025

Uh oh!

Uh oh!

15g-lucas commented Jun 5, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 5, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

GautierDele commented Jun 6, 2025 •

edited

Loading